The art of good code review
This post is an extension
to a talk I gave recently at work.
It was arranged at short notice
and the audience were experienced engineers,
so I kept it brief and tried not to be patronising.
But the feedback afterwards was quite positive
and there were some questions too,
so here's the extended version
for anyone interested.
Note that our team conducts pre-merge reviews,
and some of the suggestions are specific to that context.
I actually prefer post-merge reviews,
but am yet to persuade everyone I work with
that they're better.
Oh, and trigger warning:
this post contains opinions.
Read more